🎨Storage with Celery: unit tests working now with storage worker implemented #7438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
requested review from
GitHK,
bisgaard-itis,
giancarloromeo and
pcrespov
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7438 +/- ##
==========================================
+ Coverage 87.32% 87.44% +0.11%
==========================================
Files 1714 1708 -6
Lines 66602 66423 -179
Branches 1131 1132 +1
==========================================
- Hits 58159 58082 -77
+ Misses 8121 8020 -101
+ Partials 322 321 -1
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
bisgaard-itis
approved these changes
Mar 26, 2025
Contributor
bisgaard-itis
left a comment
bisgaard-itis
left a comment
There was a problem hiding this comment.
Very nice. Thanks a lot!
|
pcrespov
reviewed
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
this PR sets up the base framework for testing storage with a storage celery worker (fixture
with_storage_celery_worker)test/modules/celery--> gonetest_modules_celery.pynow there with example on how to use it@giancarloromeo now needs to use the redis/rabbitmq instead of cache:memory I guess.
Related issue/s
How to test
Dev-ops checklist